From: Remi Gacogne Date: Thu, 19 Nov 2020 09:53:06 +0000 (+0100) Subject: Fix the DNSName move assignement operator X-Git-Tag: rec-4.4.3~9^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F10198%2Fhead;p=thirdparty%2Fpdns.git Fix the DNSName move assignement operator A misplaced 'const' prevented it from being called, making every move of a DNSName into a full copy. Introduced in d720eb8add5ebda11867e8b404125e0b68ed2911. (cherry picked from commit 8d1bb300460d5cc97b4599ea8eddeb7b6d35decf) --- diff --git a/pdns/dnsname.hh b/pdns/dnsname.hh index 222edbaf38..20d1994b29 100644 --- a/pdns/dnsname.hh +++ b/pdns/dnsname.hh @@ -71,7 +71,7 @@ public: } return *this; } - DNSName& operator=(const DNSName&& rhs) + DNSName& operator=(DNSName&& rhs) { if (this != &rhs) { d_storage = std::move(rhs.d_storage);