From: Jeffrey Arbuckle Date: Sun, 22 Dec 2019 03:59:20 +0000 (-0500) Subject: Fix handling of invalid CAMMAC service verifier X-Git-Tag: krb5-1.18-beta1~9 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F1021%2Fhead;p=thirdparty%2Fkrb5.git Fix handling of invalid CAMMAC service verifier In extract_cammacs(), avoid a null dereference if the CAMMAC service verifier is invalid or the CAMMAC is empty. ticket: 8856 tags: pullup target_version: 1.17-next --- diff --git a/src/lib/krb5/krb/authdata.c b/src/lib/krb5/krb/authdata.c index 3685fcd916..7f28883be6 100644 --- a/src/lib/krb5/krb/authdata.c +++ b/src/lib/krb5/krb/authdata.c @@ -557,6 +557,8 @@ extract_cammacs(krb5_context kcontext, krb5_authdata **cammacs, if (ret && ret != KRB5KRB_AP_ERR_BAD_INTEGRITY) goto cleanup; ret = 0; + if (elements == NULL) + continue; /* Add the verified elements to list and free the container array. */ for (n_elements = 0; elements[n_elements] != NULL; n_elements++);