From: Otto <otto.moerbeek@open-xchange.com>
Date: Tue, 20 Apr 2021 11:52:38 +0000 (+0200)
Subject: Also check query type
X-Git-Tag: rec-4.5.0-rc1~3^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F10320%2Fhead;p=thirdparty%2Fpdns.git

Also check query type

(cherry picked from commit 660a62d41320e484387e3d4671ec36cf0d07b942)
---

diff --git a/pdns/syncres.cc b/pdns/syncres.cc
index 32f4cd4d55..a1cc8fc7fc 100644
--- a/pdns/syncres.cc
+++ b/pdns/syncres.cc
@@ -3418,7 +3418,7 @@ bool SyncRes::processRecords(const std::string& prefix, const DNSName& qname, co
       lwr.d_rcode == RCode::NXDomain && qname.isPartOf(rec.d_name) && rec.d_name.isPartOf(auth);
 
     bool putInNegCache = true;
-    if (negCacheIndiction && isForwardOrAuth(qname)) {
+    if (negCacheIndiction && qtype == QType::DS && isForwardOrAuth(qname)) {
       // #10189, a NXDOMAIN to a DS query for a forwarded or auth domain should not NXDOMAIN the whole domain
       putInNegCache = false;
     }