From: Otto <otto.moerbeek@open-xchange.com>
Date: Wed, 27 Oct 2021 07:38:10 +0000 (+0200)
Subject: wipe-cache-typed  should check if a qtype arg is present and valid
X-Git-Tag: rec-4.5.7~1^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F10911%2Fhead;p=thirdparty%2Fpdns.git

wipe-cache-typed  should check if a qtype arg is present and valid

(cherry picked from commit a721f7b21a75cefaa189bf84b14979facde7d3ab)
---

diff --git a/pdns/rec_channel_rec.cc b/pdns/rec_channel_rec.cc
index 44913e44fb..da4216aa0c 100644
--- a/pdns/rec_channel_rec.cc
+++ b/pdns/rec_channel_rec.cc
@@ -1855,7 +1855,13 @@ RecursorControlChannel::Answer RecursorControlParser::getAnswer(int s, const str
     return {0, doWipeCache(begin, end, 0xffff)};
   }
   if (cmd == "wipe-cache-typed") {
+    if (begin == end) {
+      return {1, "Need a qtype\n"};
+    }
     uint16_t qtype = QType::chartocode(begin->c_str());
+    if (qtype == 0) {
+      return {1, "Unknown qtype " + *begin + "\n"};
+    }
     ++begin;
     return {0, doWipeCache(begin, end, qtype)};
   }