From: Daniel Ruf <daniel@daniel-ruf.de>
Date: Tue, 13 Feb 2018 19:38:02 +0000 (+0100)
Subject: Revert "fix: fix side-effect of jQuery .filter() in Abide.addA11yAttributes", fixes... 
X-Git-Tag: v6.6.0~3^2~299^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F10936%2Fhead;p=thirdparty%2Ffoundation%2Ffoundation-sites.git

Revert "fix: fix side-effect of jQuery .filter() in Abide.addA11yAttributes", fixes #10935

This reverts commit c6a69067701b24ceaccd2bad625c37898ad0b445.
---

diff --git a/js/foundation.abide.js b/js/foundation.abide.js
index b307f29a5..5a7281906 100644
--- a/js/foundation.abide.js
+++ b/js/foundation.abide.js
@@ -213,8 +213,8 @@ class Abide extends Plugin {
    */
   addA11yAttributes($el) {
     let $errors = this.findFormError($el);
-    let $labels = $errors.filter('label').end();
-    let $error = $errors.first().end();
+    let $labels = $errors.filter('label');
+    let $error = $errors.first();
     if (!$errors.length) return;
 
     // Set [aria-describedby] on the input toward the first form error if it is not set
@@ -229,7 +229,7 @@ class Abide extends Plugin {
       $el.attr('aria-describedby', errorId);
     }
 
-    if ($labels.filter('[for]').end().length < $labels.length) {
+    if ($labels.filter('[for]').length < $labels.length) {
       // Get the input ID or create one
       let elemId = $el.attr('id');
       if (typeof elemId === 'undefined') {
@@ -242,7 +242,7 @@ class Abide extends Plugin {
         const $label = $(label);
         if (typeof $label.attr('for') === 'undefined')
           $label.attr('for', elemId);
-      }).end();
+      });
     }
 
     // For each error targeting $el, set [role=alert] if it is not set.