From: Nicolas Coden <nicolas@ncoden.fr>
Date: Fri, 30 Mar 2018 21:02:15 +0000 (+0200)
Subject: fix: revert to Sass default 5-digit precision for breakpoint gutters
X-Git-Tag: v6.6.0~3^2~255^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F10978%2Fhead;p=thirdparty%2Ffoundation%2Ffoundation-sites.git

fix: revert to Sass default 5-digit precision for breakpoint gutters

I was wrong, Sass actually has a default precision of 5 digits. Bootstrap-sass uses 8 digits but require to update the Sass compiler options.
See: https://github.com/twbs/bootstrap-sass#sass-number-precision

Note: this also update breakpoint tests
---

diff --git a/scss/components/_visibility.scss b/scss/components/_visibility.scss
index f649055cb..75472918a 100644
--- a/scss/components/_visibility.scss
+++ b/scss/components/_visibility.scss
@@ -6,7 +6,7 @@
 /// @param {Keyword} $size - Breakpoint to use. **Must be a breakpoint defined in `$breakpoints`.**
 @mixin show-for($size) {
   $size: map-get($breakpoints, $size);
-  $size: -zf-bp-to-em($size) - .000001;
+  $size: -zf-bp-to-em($size) - .00001;
 
   @include breakpoint($size down) {
     display: none !important;
@@ -20,7 +20,7 @@
   $upper-bound-size: -zf-map-next($breakpoints, $size);
 
   // more often than not this will be correct, just one time round the loop it won't so set in scope here
-  $lower-bound: -zf-bp-to-em($lower-bound-size) - .000001;
+  $lower-bound: -zf-bp-to-em($lower-bound-size) - .00001;
   // test actual lower-bound-size, if 0 set it to 0em
   @if strip-unit($lower-bound-size) == 0 {
     $lower-bound: -zf-bp-to-em($lower-bound-size);
diff --git a/scss/util/_breakpoint.scss b/scss/util/_breakpoint.scss
index 9865ed520..733dab09c 100644
--- a/scss/util/_breakpoint.scss
+++ b/scss/util/_breakpoint.scss
@@ -77,7 +77,7 @@ $breakpoint-classes: (small medium large) !default;
   // Convert any pixel, rem, or unitless value to em
   $bp: -zf-bp-to-em($bp);
   @if $bp-max {
-    $bp-max: -zf-bp-to-em($bp-max) - .000001;
+    $bp-max: -zf-bp-to-em($bp-max) - .00001;
   }
 
   // Conditions to skip media query creation
diff --git a/test/sass/_breakpoint.scss b/test/sass/_breakpoint.scss
index ef2754fac..1ea9badf9 100755
--- a/test/sass/_breakpoint.scss
+++ b/test/sass/_breakpoint.scss
@@ -24,10 +24,10 @@
 
   @include test('Breakpoint (Only Range) [function]') {
     $test: breakpoint(medium only);
-    $expect: '(min-width: 40em) and (max-width: 63.9999em)';
+    $expect: '(min-width: 40em) and (max-width: 63.99999em)';
 
     $test-lowest: breakpoint(small only);
-    $expect-lowest: '(max-width: 39.9999em)';
+    $expect-lowest: '(max-width: 39.99999em)';
 
     $test-highest: breakpoint(xxlarge only);
     $expect-highest: '(min-width: 90em)';
@@ -44,13 +44,13 @@
 
   @include test('Breakpoint (Named Down Range) [function]') {
     $test: breakpoint(medium down);
-    $expect: '(max-width: 63.9999em)';
+    $expect: '(max-width: 63.99999em)';
 
     @include assert-equal($test, $expect,
       'Creates a down range out of a medium breakpoint');
 
     $test-lowest: breakpoint(small down);
-    $expect-lowest: '(max-width: 39.9999em)';
+    $expect-lowest: '(max-width: 39.99999em)';
 
     @include assert-equal($test-lowest, $expect-lowest,
       'Creates a down range out of a small breakpoint');