From: Nicolas Coden <nicolas@ncoden.fr>
Date: Wed, 11 Apr 2018 20:10:39 +0000 (+0200)
Subject: fix: reset all OffCanvas properties when in in-canvas mode
X-Git-Tag: v6.6.0~3^2~238^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F11141%2Fhead;p=thirdparty%2Ffoundation%2Ffoundation-sites.git

fix: reset all OffCanvas properties when in in-canvas mode

> Done some research. The incanvas feature always used `inherit`, without explicit reasons given. Most font properties should inherit but not `background`, `width`, `overflow`, `transition` as this is not their default value. I'll replace all of them.

See https://github.com/zurb/foundation-sites/pull/11141#discussion_r180879166
---

diff --git a/scss/components/_off-canvas.scss b/scss/components/_off-canvas.scss
index bbee8cb27..120976517 100644
--- a/scss/components/_off-canvas.scss
+++ b/scss/components/_off-canvas.scss
@@ -416,10 +416,10 @@ $breakpoint: small
   visibility: visible;
   height: auto;
   position: static;
-  background: inherit;
+  background: none;
   width: auto;
-  overflow: inherit;
-  transition: inherit;
+  overflow: visible;
+  transition: none;
 
   // Increase CSS specificity
   &.position-left,