From: Nicolas Coden Date: Fri, 25 May 2018 21:17:25 +0000 (+0200) Subject: fix: use fallback gutter for fallback breakpoint in XY cell #11194 X-Git-Tag: v6.6.0~3^2~164^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F11300%2Fhead;p=thirdparty%2Ffoundation%2Ffoundation-sites.git fix: use fallback gutter for fallback breakpoint in XY cell #11194 When no breakpoint is passed to `xy-cell` and a fallback "zero" breakpoint is used, use a fallback gutter as well if it is not found. This way, an implicit behavior stay implicit and a warning is thrown only if a breakpoint was explicitely given. Closes https://github.com/zurb/foundation-sites/issues/11194 --- diff --git a/scss/xy-grid/_cell.scss b/scss/xy-grid/_cell.scss index 03bc425f3..6e811e9e9 100644 --- a/scss/xy-grid/_cell.scss +++ b/scss/xy-grid/_cell.scss @@ -110,6 +110,8 @@ $breakpoint: null, $vertical: false ) { + $bp-is-fallback: false; + @if($breakpoint == null) { // If `$bp-size` is available then use this, otherwise revert to the smallest bp. @if(variable-exists(-zf-size) and type-of($-zf-size) != 'number') and $-zf-size != null { @@ -117,11 +119,16 @@ } @else { $breakpoint: $-zf-zero-breakpoint; + $bp-is-fallback: true; } } - // Get the gutter for the passed breakpoint/value. + // Get the gutter for the given breakpoint/value. $gutter: -zf-get-bp-val($gutters, $breakpoint); + // If the breakpoint is a fallback, use a fallback gutter as well + @if ($bp-is-fallback == true and $gutter == null) { + $gutter: 0; + } @if($gutter != null) { // Base flex properties