From: Philippe Antoine <pantoine@oisf.net>
Date: Wed, 19 Jun 2024 14:45:03 +0000 (+0200)
Subject: detect: remove unused field
X-Git-Tag: suricata-8.0.0-beta1~1133
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F11331%2Fhead;p=thirdparty%2Fsuricata.git

detect: remove unused field

content_inspect_window is used in app-layer-smtp, but
not directly in detect-file-data
---

diff --git a/src/detect-file-data.c b/src/detect-file-data.c
index 312e3aaac8..732dfd6373 100644
--- a/src/detect-file-data.c
+++ b/src/detect-file-data.c
@@ -101,15 +101,14 @@ static void SetupDetectEngineConfig(DetectEngineCtx *de_ctx) {
     for (int i = 0; i < (int)ALPROTO_MAX; i++) {
         de_ctx->filedata_config[i].content_limit = FILEDATA_CONTENT_LIMIT;
         de_ctx->filedata_config[i].content_inspect_min_size = FILEDATA_CONTENT_INSPECT_MIN_SIZE;
-        de_ctx->filedata_config[i].content_inspect_window = FILEDATA_CONTENT_INSPECT_WINDOW;
     }
 
     /* add protocol specific settings here */
 
     /* SMTP */
     de_ctx->filedata_config[ALPROTO_SMTP].content_limit = smtp_config.content_limit;
-    de_ctx->filedata_config[ALPROTO_SMTP].content_inspect_min_size = smtp_config.content_inspect_min_size;
-    de_ctx->filedata_config[ALPROTO_SMTP].content_inspect_window = smtp_config.content_inspect_window;
+    de_ctx->filedata_config[ALPROTO_SMTP].content_inspect_min_size =
+            smtp_config.content_inspect_min_size;
 
     de_ctx->filedata_config_initialized = true;
 }
diff --git a/src/detect.h b/src/detect.h
index 6a2d9c2792..26cff6352e 100644
--- a/src/detect.h
+++ b/src/detect.h
@@ -957,7 +957,6 @@ typedef struct DetectEngineCtx_ {
     struct {
         uint32_t content_limit;
         uint32_t content_inspect_min_size;
-        uint32_t content_inspect_window;
     } filedata_config[ALPROTO_MAX];
 
 #ifdef PROFILE_RULES