From: Philippe Antoine <pantoine@oisf.net>
Date: Tue, 2 Jul 2024 07:26:23 +0000 (+0200)
Subject: detect/snmp: do not bother to free a null pointer
X-Git-Tag: suricata-7.0.7~73
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F11419%2Fhead;p=thirdparty%2Fsuricata.git

detect/snmp: do not bother to free a null pointer

Ticket: 7134
---

diff --git a/src/detect-snmp-version.c b/src/detect-snmp-version.c
index 57359c091b..deb73b9bcd 100644
--- a/src/detect-snmp-version.c
+++ b/src/detect-snmp-version.c
@@ -140,7 +140,7 @@ static int DetectSNMPVersionSetup (DetectEngineCtx *de_ctx, Signature *s,
     dd = DetectSNMPVersionParse(rawstr);
     if (dd == NULL) {
         SCLogError("Parsing \'%s\' failed", rawstr);
-        goto error;
+        return -1;
     }
 
     /* okay so far so good, lets get this into a SigMatch