From: Zdenek Dohnal <zdohnal@redhat.com>
Date: Wed, 12 Mar 2025 12:19:04 +0000 (+0100)
Subject: backend/ipp.c: Raise alert if there is issue with cert
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F1194%2Fhead;p=thirdparty%2Fcups.git

backend/ipp.c: Raise alert if there is issue with cert

Currently we show more detailed info about this error in debug logs, but
since there are not many desktops to pick up our dBUS notification, it
would be great to report it in CUPS log too.
---

diff --git a/backend/ipp.c b/backend/ipp.c
index 894f86536e..7b9f9496a1 100644
--- a/backend/ipp.c
+++ b/backend/ipp.c
@@ -800,12 +800,12 @@ main(int  argc,				/* I - Number of command-line args */
 					/* Trust keywords */
     static const char	* const trust_msgs[] =
     {
-      "Credentials are OK/trusted",
-      "Credentials are invalid",
-      "Credentials have changed",
-      "Credentials are expired",
-      "Credentials have been renewed",
-      "Credentials are unknown/new"
+      _("Credentials are OK/trusted."),
+      _("Credentials are invalid."),
+      _("Credentials have changed."),
+      _("Credentials are expired."),
+      _("Credentials have been renewed."),
+      _("Credentials are unknown/new.")
     };
 
     fputs("DEBUG: Connection is encrypted.\n", stderr);
@@ -820,19 +820,20 @@ main(int  argc,				/* I - Number of command-line args */
 
       if ((lcreds = cupsCopyCredentials(NULL, hostname)) != NULL)
       {
-        cupsGetCredentialsInfo(lcreds, lcredinfo, sizeof(lcredinfo));
+	cupsGetCredentialsInfo(lcreds, lcredinfo, sizeof(lcredinfo));
 	fprintf(stderr, "DEBUG: Stored credentials: %s\n", lcredinfo);
       }
       else
       {
-        fputs("DEBUG: No stored credentials.\n", stderr);
+	fputs("DEBUG: No stored credentials.\n", stderr);
       }
 
       update_reasons(NULL, "-cups-pki-invalid,cups-pki-changed,cups-pki-expired,cups-pki-unknown");
       if (trusts[trust])
       {
-        update_reasons(NULL, trusts[trust]);
-        return (CUPS_BACKEND_STOP);
+	update_reasons(NULL, trusts[trust]);
+	_cupsLangPrintFilter(stderr, "ALERT", "%s", trust_msgs[trust]);
+	return (CUPS_BACKEND_STOP);
       }
 
      /*