From: Victor Julien <victor@inliniac.net>
Date: Fri, 31 Oct 2014 13:56:14 +0000 (+0100)
Subject: Fix Coverity issue in SMTP output
X-Git-Tag: suricata-2.1beta2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F1196%2Fhead;p=thirdparty%2Fsuricata.git

Fix Coverity issue in SMTP output

** CID 1250327:  Uninitialized pointer read  (UNINIT)
/src/output-json-email-common.c: 117 in JsonEmailLogJson()
/src/output-json-email-common.c: 139 in JsonEmailLogJson()
---

diff --git a/src/output-json-email-common.c b/src/output-json-email-common.c
index 5b1e19f419..f12a0e1812 100644
--- a/src/output-json-email-common.c
+++ b/src/output-json-email-common.c
@@ -114,7 +114,7 @@ static TmEcode JsonEmailLogJson(JsonEmailLogThread *aft, json_t *js, const Packe
             if (field != NULL) {
                 json_t *js_to = json_array();
                 if (likely(js_to != NULL)) {
-                    char *savep;
+                    char *savep = NULL;
                     char *p;
                     to_line = BytesToString((uint8_t *)field->value,
                                             (size_t)field->value_len);
@@ -136,7 +136,7 @@ static TmEcode JsonEmailLogJson(JsonEmailLogThread *aft, json_t *js, const Packe
             if (field != NULL) {
                 json_t *js_cc = json_array();
                 if (likely(js_cc != NULL)) {
-                    char *savep;
+                    char *savep = NULL;
                     char *p;
                     cc_line = BytesToString((uint8_t *)field->value,
                                             (size_t)field->value_len);