From: Viicos <65306057+Viicos@users.noreply.github.com> Date: Fri, 24 Mar 2023 10:15:01 +0000 (+0100) Subject: Fix type annotation for `url` X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F1209%2Fhead;p=thirdparty%2Fsqlalchemy%2Falembic.git Fix type annotation for `url` --- diff --git a/alembic/runtime/environment.py b/alembic/runtime/environment.py index 0f9d3a56..c2fa11ad 100644 --- a/alembic/runtime/environment.py +++ b/alembic/runtime/environment.py @@ -20,6 +20,7 @@ from ..operations import Operations if TYPE_CHECKING: from typing import Literal + from sqlalchemy.engine import URL from sqlalchemy.engine.base import Connection from sqlalchemy.sql.elements import ClauseElement from sqlalchemy.sql.schema import MetaData @@ -334,7 +335,7 @@ class EnvironmentContext(util.ModuleClsProxy): def configure( self, connection: Optional[Connection] = None, - url: Optional[str] = None, + url: Optional[Union[str, URL]] = None, dialect_name: Optional[str] = None, dialect_opts: Optional[Dict[str, Any]] = None, transactional_ddl: Optional[bool] = None, diff --git a/alembic/runtime/migration.py b/alembic/runtime/migration.py index a6156511..4b93ef74 100644 --- a/alembic/runtime/migration.py +++ b/alembic/runtime/migration.py @@ -33,7 +33,7 @@ from ..util import sqla_compat from ..util.compat import EncodedIO if TYPE_CHECKING: - from sqlalchemy.engine import Dialect + from sqlalchemy.engine import Dialect, URL from sqlalchemy.engine.base import Connection from sqlalchemy.engine.base import Transaction from sqlalchemy.engine.mock import MockConnection @@ -217,7 +217,7 @@ class MigrationContext: def configure( cls, connection: Optional[Connection] = None, - url: Optional[str] = None, + url: Optional[Union[str, URL]] = None, dialect_name: Optional[str] = None, dialect: Optional[Dialect] = None, environment_context: Optional[EnvironmentContext] = None,