From: Jorge Pereira <jpereiran@gmail.com>
Date: Thu, 17 Sep 2015 12:45:47 +0000 (-0300)
Subject: if try to load a wrong client from SQL, don't start
X-Git-Tag: release_3_0_10~77^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F1242%2Fhead;p=thirdparty%2Ffreeradius-server.git

if try to load a wrong client from SQL, don't start
---

diff --git a/src/modules/rlm_sql/rlm_sql.c b/src/modules/rlm_sql/rlm_sql.c
index e1e18c9c31..f9358ad52f 100644
--- a/src/modules/rlm_sql/rlm_sql.c
+++ b/src/modules/rlm_sql/rlm_sql.c
@@ -272,6 +272,7 @@ static int generate_sql_clients(rlm_sql_t *inst)
 	rlm_sql_handle_t *handle;
 	rlm_sql_row_t row;
 	unsigned int i = 0;
+	int ret = 0;
 	RADCLIENT *c;
 
 	DEBUG("rlm_sql (%s): Processing generate_sql_clients",
@@ -340,7 +341,8 @@ static int generate_sql_clients(rlm_sql_t *inst)
 			WARN("Failed to add client, possible duplicate?");
 
 			client_free(c);
-			continue;
+			ret = -1;
+			break;
 		}
 
 		DEBUG("rlm_sql (%s): Client \"%s\" (%s) added", c->longname, c->shortname,
@@ -350,7 +352,7 @@ static int generate_sql_clients(rlm_sql_t *inst)
 	(inst->module->sql_finish_select_query)(handle, inst->config);
 	fr_connection_release(inst->pool, handle);
 
-	return 0;
+	return ret;
 }