From: Jeff Lucovsky <jlucovsky@oisf.net>
Date: Mon, 14 Apr 2025 20:07:24 +0000 (-0400)
Subject: output/rotate: Remove extra rotation flag register
X-Git-Tag: suricata-8.0.0-rc1~463
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F13035%2Fhead;p=thirdparty%2Fsuricata.git

output/rotate: Remove extra rotation flag register

Issue: 3436

Remove duplicate register of the rotation flag. Eventually, this will
cause corruption when the file context has been freed and the rotation
flag is deregistered.
---

diff --git a/src/output-json.c b/src/output-json.c
index b1f327580a..ba3692572e 100644
--- a/src/output-json.c
+++ b/src/output-json.c
@@ -1068,7 +1068,6 @@ static int LogFileTypePrepare(
         if (SCConfLogOpenGeneric(conf, json_ctx->file_ctx, DEFAULT_LOG_FILENAME, 1) < 0) {
             return -1;
         }
-        OutputRegisterFileRotationFlag(&json_ctx->file_ctx->rotation_flag);
     }
 #ifdef HAVE_LIBHIREDIS
     else if (log_filetype == LOGFILE_TYPE_REDIS) {