From: Jorge Pereira <jpereiran@gmail.com>
Date: Wed, 21 Oct 2015 02:13:04 +0000 (-0200)
Subject: Fix memory leak on invalid dhcp packet
X-Git-Tag: release_3_0_11~233^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F1335%2Fhead;p=thirdparty%2Ffreeradius-server.git

Fix memory leak on invalid dhcp packet
---

diff --git a/src/modules/proto_dhcp/dhcp.c b/src/modules/proto_dhcp/dhcp.c
index 2754ccd2da..204f87ad9d 100644
--- a/src/modules/proto_dhcp/dhcp.c
+++ b/src/modules/proto_dhcp/dhcp.c
@@ -877,6 +877,7 @@ ssize_t fr_dhcp_decode_options(TALLOC_CTX *ctx, VALUE_PAIR **out, uint8_t const
 		if ((a_p + a_len) > q) {
 			fr_strerror_printf("Length field value of option %u is incorrect.  "
 					   "Got %u bytes, expected <= %zu bytes", p[0], p[1], q - a_p);
+			fr_pair_list_free(out);
 			return -1;
 		}