From: Yusuf Simonson <simonson@gmail.com>
Date: Sat, 7 Mar 2015 17:34:37 +0000 (-0500)
Subject: Prevent bad calls to get_arguments with a presumed default value
X-Git-Tag: v4.2.0b1~79^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F1371%2Fhead;p=thirdparty%2Ftornado.git

Prevent bad calls to get_arguments with a presumed default value
---

diff --git a/tornado/web.py b/tornado/web.py
index f4e8a84aa..6d37f7050 100644
--- a/tornado/web.py
+++ b/tornado/web.py
@@ -392,6 +392,12 @@ class RequestHandler(object):
 
         The returned values are always unicode.
         """
+
+        # Make sure `get_arguments` isn't accidentally being called with a
+        # positional argument that's assumed to be a default (like in
+        # `get_argument`.)
+        assert isinstance(strip, bool)
+
         return self._get_arguments(name, self.request.arguments, strip)
 
     def get_body_argument(self, name, default=_ARG_DEFAULT, strip=True):