From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Fri, 19 Jan 2024 14:26:21 +0000 (+0100)
Subject: getAllDomains catalog: avoid useless copy
X-Git-Tag: dnsdist-1.9.0-rc1~23^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F13729%2Fhead;p=thirdparty%2Fpdns.git

getAllDomains catalog: avoid useless copy
---

diff --git a/pdns/backends/gsql/gsqlbackend.cc b/pdns/backends/gsql/gsqlbackend.cc
index ce14715678..8ebb3c8acf 100644
--- a/pdns/backends/gsql/gsqlbackend.cc
+++ b/pdns/backends/gsql/gsqlbackend.cc
@@ -1759,7 +1759,9 @@ void GSQLBackend::getAllDomains(vector<DomainInfo>* domains, bool getSerial, boo
       pdns::checked_stoi_into(di.id, row[0]);
       try {
         di.zone = DNSName(row[1]);
-        di.catalog = (!row[8].empty() ? DNSName(row[8]) : DNSName());
+        if (!row[8].empty()) {
+          di.catalog = DNSName(row[8]);
+        }
       } catch (...) {
         continue;
       }