From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Mon, 12 Feb 2024 09:08:56 +0000 (+0100)
Subject: dnsdist: Fix performance inefficiencies reported by Coverity
X-Git-Tag: dnsdist-1.9.0~2^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F13779%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Fix performance inefficiencies reported by Coverity

Reported by Coverity as 414759 and 414760:
> Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
---

diff --git a/pdns/dnsdistdist/doh3.cc b/pdns/dnsdistdist/doh3.cc
index f24e66c878..d5216aa640 100644
--- a/pdns/dnsdistdist/doh3.cc
+++ b/pdns/dnsdistdist/doh3.cc
@@ -439,7 +439,7 @@ static std::optional<std::reference_wrapper<H3Connection>> createConnection(DOH3
     quiche_conn_set_keylog_path(quicheConn.get(), config.df->d_quicheParams.d_keyLogFile.c_str());
   }
 
-  auto conn = H3Connection(peer, quicheConfig, std::move(quicheConn));
+  auto conn = H3Connection(peer, std::move(quicheConfig), std::move(quicheConn));
   auto pair = config.d_connections.emplace(serverSideID, std::move(conn));
   return pair.first->second;
 }
diff --git a/pdns/dnsdistdist/doq.cc b/pdns/dnsdistdist/doq.cc
index f3f0b40e46..247b67a004 100644
--- a/pdns/dnsdistdist/doq.cc
+++ b/pdns/dnsdistdist/doq.cc
@@ -356,7 +356,7 @@ static std::optional<std::reference_wrapper<Connection>> createConnection(DOQSer
     quiche_conn_set_keylog_path(quicheConn.get(), config.df->d_quicheParams.d_keyLogFile.c_str());
   }
 
-  auto conn = Connection(peer, quicheConfig, std::move(quicheConn));
+  auto conn = Connection(peer, std::move(quicheConfig), std::move(quicheConn));
   auto pair = config.d_connections.emplace(serverSideID, std::move(conn));
   return pair.first->second;
 }