From: Andrey Volk Date: Tue, 19 Oct 2021 00:03:55 +0000 (+0300) Subject: [mod_verto] scan-build: fix false-positive Argument with 'nonnull' attribute passed... X-Git-Tag: v1.10.7^2~225^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F1390%2Fhead;p=thirdparty%2Ffreeswitch.git [mod_verto] scan-build: fix false-positive Argument with 'nonnull' attribute passed null in check_auth --- diff --git a/src/mod/endpoints/mod_verto/mod_verto.c b/src/mod/endpoints/mod_verto/mod_verto.c index dba9d63208..06cb6c7652 100644 --- a/src/mod/endpoints/mod_verto/mod_verto.c +++ b/src/mod/endpoints/mod_verto/mod_verto.c @@ -1050,7 +1050,7 @@ static switch_bool_t check_auth(jsock_t *jsock, cJSON *params, int *code, char * } - if (zstr(use_passwd) || strcmp(a1_hash ? a1_hash : passwd, use_passwd)) { + if (!use_passwd || zstr(use_passwd) || strcmp(a1_hash ? a1_hash : passwd, use_passwd)) { r = SWITCH_FALSE; *code = CODE_AUTH_FAILED; switch_snprintf(message, mlen, "Authentication Failure");