From: Julien Rische <jrische@redhat.com>
Date: Wed, 8 Jan 2025 11:36:07 +0000 (+0100)
Subject: Remove redundant check in acquire_cred_from()
X-Git-Tag: krb5-1.22-beta1~34
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F1407%2Fhead;p=thirdparty%2Fkrb5.git

Remove redundant check in acquire_cred_from()

When processing KRB5_CS_PASSWORD_URN, only check for null desired_name
once.

[ghudson@mit.edu: edited commit message]
---

diff --git a/src/lib/gssapi/krb5/acquire_cred.c b/src/lib/gssapi/krb5/acquire_cred.c
index 006eba114d..d49ad07ea4 100644
--- a/src/lib/gssapi/krb5/acquire_cred.c
+++ b/src/lib/gssapi/krb5/acquire_cred.c
@@ -1283,8 +1283,8 @@ acquire_cred_from(OM_uint32 *minor_status, const gss_name_t desired_name,
             ret = GSS_S_BAD_NAME;
             goto out;
         }
-        if (cred_usage == GSS_C_ACCEPT || desired_name == GSS_C_NO_NAME ||
-            ccache != NULL || client_keytab != NULL) {
+        if (cred_usage == GSS_C_ACCEPT || ccache != NULL ||
+            client_keytab != NULL) {
             *minor_status = (OM_uint32)G_BAD_USAGE;
             ret = GSS_S_FAILURE;
             goto out;