From: Greg Hudson <ghudson@mit.edu>
Date: Fri, 18 Apr 2025 06:59:33 +0000 (-0400)
Subject: Fix kdb5_util ark with no -e option
X-Git-Tag: krb5-1.22-beta1~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F1427%2Fhead;p=thirdparty%2Fkrb5.git

Fix kdb5_util ark with no -e option

Avoid passing NULL to krb5_string_to_keysalt() in add_random_key().
When add_random_key() was first written, krb5_string_to_keysalts() did
nothing on a null string input.  After commit
3576bd662be9b7cc2cca97065fe467e745542b69 it calls strdup(NULL) and
crashes.
---

diff --git a/src/kadmin/dbutil/kdb5_util.c b/src/kadmin/dbutil/kdb5_util.c
index 88218dba74..96b4a2571d 100644
--- a/src/kadmin/dbutil/kdb5_util.c
+++ b/src/kadmin/dbutil/kdb5_util.c
@@ -522,7 +522,7 @@ add_random_key(int argc, char **argv)
 
     int free_keysalts;
     char *me = progname;
-    char *ks_str = NULL;
+    char *ks_str = "";
     char *pr_str;
     krb5_keyblock *tmp_mkey;