From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Mon, 12 May 2025 08:58:42 +0000 (+0200)
Subject: dnsdist: Apply better syntax suggestion from Otto (thanks)
X-Git-Tag: dnsdist-2.0.0-alpha2~21^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F15539%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: Apply better syntax suggestion from Otto (thanks)
---

diff --git a/pdns/dnsdistdist/dnsdist-lua.cc b/pdns/dnsdistdist/dnsdist-lua.cc
index c7c19071d2..58967406a7 100644
--- a/pdns/dnsdistdist/dnsdist-lua.cc
+++ b/pdns/dnsdistdist/dnsdist-lua.cc
@@ -1907,14 +1907,14 @@ static void setupLuaConfig(LuaContext& luaCtx, bool client, bool configCheck)
   });
 
   luaCtx.writeFunction("setAPIWritable", [](bool writable, boost::optional<std::string> apiConfigDir) {
-    if (apiConfigDir && (*apiConfigDir).empty()) {
+    if (apiConfigDir && apiConfigDir->empty()) {
       errlog("The API configuration directory value cannot be empty!");
       g_outputBuffer = "The API configuration directory value cannot be empty!";
       return;
     }
     dnsdist::configuration::updateRuntimeConfiguration([writable, &apiConfigDir](dnsdist::configuration::RuntimeConfiguration& config) {
       config.d_apiReadWrite = writable;
-      if (apiConfigDir && !(*apiConfigDir).empty()) {
+      if (apiConfigDir && !apiConfigDir->empty()) {
         config.d_apiConfigDirectory = *apiConfigDir;
       }
     });