From: Kevin Kirsche Date: Thu, 29 Jan 2015 13:19:09 +0000 (-0500) Subject: [Fixes #15691] .form-control-static changes height when empty X-Git-Tag: v3.3.4~109^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F15699%2Fhead;p=thirdparty%2Fbootstrap.git [Fixes #15691] .form-control-static changes height when empty [Fixes #15691] .form-control-static changes height when empty by setting the minimum height to the size it is when text is in the `.form-control-static` JSFiddle: http://jsfiddle.net/4pdo4yzo/ Compute the minimum height @line-height-computed = ~20px @font-size-base = 14px This should come to approx. 34px Add min-height to from-group-* per @cvrebert I had this wrong. The minimum height would depend on the font-size of that specific group, thus we need to declare it once for font-size-small and once also for font-size-large --- diff --git a/less/forms.less b/less/forms.less index 3138c2c518..a0840cd4f8 100644 --- a/less/forms.less +++ b/less/forms.less @@ -294,6 +294,7 @@ input[type="checkbox"] { padding-bottom: (@padding-base-vertical + 1); // Remove default margin from `p` margin-bottom: 0; + min-height: (@line-height-computed + @font-size-base); &.input-lg, &.input-sm { @@ -323,6 +324,7 @@ input[type="checkbox"] { padding: @padding-small-vertical @padding-small-horizontal; font-size: @font-size-small; line-height: @line-height-small; + min-height: (@line-height-computed + @font-size-small); } } @@ -338,6 +340,7 @@ input[type="checkbox"] { padding: @padding-large-vertical @padding-large-horizontal; font-size: @font-size-large; line-height: @line-height-large; + min-height: (@line-height-computed + @font-size-large); } }