From: Josh Soref <2119212+jsoref@users.noreply.github.com>
Date: Thu, 4 Dec 2025 14:10:25 +0000 (-0500)
Subject: Promtool may return 3 because of the "_total" suffix warnings
X-Git-Tag: rec-5.4.0-alpha1~26^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F16594%2Fhead;p=thirdparty%2Fpdns.git

Promtool may return 3 because of the "_total" suffix warnings

Co-authored-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
---

diff --git a/regression-tests.dnsdist/test_Prometheus.py b/regression-tests.dnsdist/test_Prometheus.py
index b41ce956b8..57e5cc0657 100644
--- a/regression-tests.dnsdist/test_Prometheus.py
+++ b/regression-tests.dnsdist/test_Prometheus.py
@@ -94,7 +94,7 @@ class TestPrometheus(DNSDistTest):
         except subprocess.CalledProcessError as exc:
             raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, process.output))
 
-        # promtool returns 3 because of the "_total" suffix warnings
+        # promtool may return 3 because of the "_total" suffix warnings
         if not process.returncode in [0, 3]:
           raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, output))
 
diff --git a/regression-tests.ixfrdist/test_Stats.py b/regression-tests.ixfrdist/test_Stats.py
index a8d4e69d41..bc1bf3d74d 100644
--- a/regression-tests.ixfrdist/test_Stats.py
+++ b/regression-tests.ixfrdist/test_Stats.py
@@ -60,7 +60,7 @@ webserver-address: %s
         except subprocess.CalledProcessError as exc:
             raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, process.output))
 
-        # promtool returns 3 because of the "_total" suffix warnings
+        # promtool may return 3 because of the "_total" suffix warnings
         if not process.returncode in [0, 3]:
           raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, output))
 
diff --git a/regression-tests.recursor-dnssec/test_Prometheus.py b/regression-tests.recursor-dnssec/test_Prometheus.py
index a618ae4db4..d826fd3105 100644
--- a/regression-tests.recursor-dnssec/test_Prometheus.py
+++ b/regression-tests.recursor-dnssec/test_Prometheus.py
@@ -29,7 +29,7 @@ class RecPrometheusTest(RecursorTest):
         except subprocess.CalledProcessError as exc:
             raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, process.output))
 
-        # promtool returns 3 because of the "_total" suffix warnings
+        # promtool may return 3 because of the "_total" suffix warnings
         if not process.returncode in [0, 3]:
           raise AssertionError('%s failed (%d): %s' % (testcmd, process.returncode, output))