From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Tue, 6 Jan 2026 12:11:17 +0000 (+0100)
Subject: contrib: fix spurious "openTelemetry decoding not available" warning
X-Git-Tag: rec-5.4.0-beta1~58^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F16696%2Fhead;p=thirdparty%2Fpdns.git

contrib: fix spurious "openTelemetry decoding not available" warning

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
---

diff --git a/contrib/ProtobufLogger.py b/contrib/ProtobufLogger.py
index acdca7ac55..d5cf23a9f3 100644
--- a/contrib/ProtobufLogger.py
+++ b/contrib/ProtobufLogger.py
@@ -145,17 +145,18 @@ class PDNSPBConnHandler(object):
                 self.convertKV(values, key, value)
 
     def printOT(self, msg):
-        if self._printjson and opentelemetryAvailable:
-            if msg.HasField('openTelemetryData'):
-                json_string = None
-                otmsg = opentelemetry.proto.trace.v1.trace_pb2.TracesData()
-                otmsg.ParseFromString(msg.openTelemetryData)
-                values = google.protobuf.json_format.MessageToDict(otmsg, preserving_proto_field_name=True)
-                self.convertIDs(values)
-                json_string = json.dumps(values, indent=True)
-                print("- openTelemetry: " + json_string)
-        else:
-            print("- openTelemetry decoding not available, see the comments in ProtoBuffer.py to make it available.")
+        if self._printjson:
+            if opentelemetryAvailable:
+                if msg.HasField('openTelemetryData'):
+                    json_string = None
+                    otmsg = opentelemetry.proto.trace.v1.trace_pb2.TracesData()
+                    otmsg.ParseFromString(msg.openTelemetryData)
+                    values = google.protobuf.json_format.MessageToDict(otmsg, preserving_proto_field_name=True)
+                    self.convertIDs(values)
+                    json_string = json.dumps(values, indent=True)
+                    print("- openTelemetry: " + json_string)
+                else:
+                    print("- openTelemetry decoding not available, see the comments in ProtoBuffer.py to make it available.")
 
     @staticmethod
     def getAppliedPolicyTypeAsString(polType):