From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Tue, 27 Jan 2026 12:39:06 +0000 (+0100)
Subject: rec: Coverity 1644498 Variable copied when it could be moved
X-Git-Tag: dnsdist-2.1.0-alpha1~2^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F16784%2Fhead;p=thirdparty%2Fpdns.git

rec: Coverity 1644498 Variable copied when it could be moved

Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
---

diff --git a/pdns/recursordist/ws-recursor.cc b/pdns/recursordist/ws-recursor.cc
index ba9e3c4cc8..4fcab9e715 100644
--- a/pdns/recursordist/ws-recursor.cc
+++ b/pdns/recursordist/ws-recursor.cc
@@ -693,7 +693,7 @@ static void apiServerOTConditionDetailPOST(HttpRequest* req, HttpResponse* resp)
     if (auto qid = document["qid"]; qid.is_number()) {
       condition.d_qid = qid.int_value();
     }
-    (*lock)->insert(netmask).second = condition;
+    (*lock)->insert(netmask).second = std::move(condition);
     updateOTConditions(**lock);
   }
   catch (NetmaskException&) {