From: Chris Hofstaedtler <chris.hofstaedtler@deduktiva.com>
Date: Sun, 1 Feb 2026 15:04:49 +0000 (+0100)
Subject: dnsdist: SpoofAction: clarify what gets spoofed
X-Git-Tag: rec-5.5.0-alpha0~44^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F16800%2Fhead;p=thirdparty%2Fpdns.git

dnsdist: SpoofAction: clarify what gets spoofed

Signed-off-by: Chris Hofstaedtler <chris.hofstaedtler@deduktiva.com>
---

diff --git a/pdns/dnsdistdist/dnsdist-actions-factory.cc b/pdns/dnsdistdist/dnsdist-actions-factory.cc
index 8fa0e6fc6f..befe201d00 100644
--- a/pdns/dnsdistdist/dnsdist-actions-factory.cc
+++ b/pdns/dnsdistdist/dnsdist-actions-factory.cc
@@ -901,15 +901,21 @@ public:
 
   string toString() const override
   {
-    string ret = "spoof in ";
+    string ret = "spoof ";
     if (!d_cname.empty()) {
-      ret += d_cname.toString() + " ";
+      ret += "CNAME " + d_cname.toString() + " ";
     }
     if (!d_rawResponses.empty()) {
       ret += "raw bytes ";
     }
     else {
       for (const auto& addr : d_addrs) {
+        if (addr.isIPv4()) {
+          ret += "A ";
+        }
+        else if (addr.isIPv6()) {
+          ret += "AAAA ";
+        }
         ret += addr.toString() + " ";
       }
     }