From: Klemens Nanni <kn@openbsd.org>
Date: Sat, 24 Feb 2024 13:12:25 +0000 (+0100)
Subject: Avoid passing NULL pointer to printf(3) %s
X-Git-Tag: 4.3.4-dev~43^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F1810%2Fhead;p=thirdparty%2Fshairport-sync.git

Avoid passing NULL pointer to printf(3) %s

OpenBSD issues syslog(3) warnings about these as they may hint at bugs:
	shairport-sync: vfprintf %s NULL in "metadata socket address is "%s" port %d."

Metadata listener socket is empty by default so use the existing `strnull`.
---

diff --git a/shairport.c b/shairport.c
index bded4165..e5b67969 100644
--- a/shairport.c
+++ b/shairport.c
@@ -2491,7 +2491,7 @@ int main(int argc, char **argv) {
 #ifdef CONFIG_METADATA
   debug(1, "metadata enabled is %d.", config.metadata_enabled);
   debug(1, "metadata pipename is \"%s\".", config.metadata_pipename);
-  debug(1, "metadata socket address is \"%s\" port %d.", config.metadata_sockaddr,
+  debug(1, "metadata socket address is \"%s\" port %d.", strnull(config.metadata_sockaddr),
         config.metadata_sockport);
   debug(1, "metadata socket packet size is \"%d\".", config.metadata_sockmsglength);
   debug(1, "get-coverart is %d.", config.get_coverart);