From: Felix Fietkau <nbd@nbd.name>
Date: Fri, 27 Jun 2025 11:08:32 +0000 (+0200)
Subject: wifi-scripts: ucode: fix invalid generated MAC address
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F19234%2Fhead;p=thirdparty%2Fopenwrt.git

wifi-scripts: ucode: fix invalid generated MAC address

macaddr_base can be NULL, in which case it needs to be passed as an empty string

Signed-off-by: Felix Fietkau <nbd@nbd.name>
---

diff --git a/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/iface.uc b/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/iface.uc
index 780cab8a630..bfea26d462a 100644
--- a/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/iface.uc
+++ b/package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/iface.uc
@@ -231,7 +231,7 @@ function macaddr_random() {
 let mac_idx = 0;
 export function prepare(data, phy, num_global_macaddr, macaddr_base) {
 	if (!data.macaddr) {
-		let pipe = fs.popen(`ucode /usr/share/hostap/wdev.uc ${phy} get_macaddr id=${mac_idx} num_global=${num_global_macaddr} mbssid=${data.mbssid ?? 0} macaddr_base=${macaddr_base}`);
+		let pipe = fs.popen(`ucode /usr/share/hostap/wdev.uc ${phy} get_macaddr id=${mac_idx} num_global=${num_global_macaddr} mbssid=${data.mbssid ?? 0} macaddr_base=${macaddr_base ?? ""}`);
 
 		data.macaddr = trim(pipe.read("all"), '\n');
 		pipe.close();