From: Jonathan Calmels <jcalmels@nvidia.com>
Date: Mon, 11 Dec 2017 22:49:57 +0000 (-0800)
Subject: overlay: fix out-of-bounds copy
X-Git-Tag: lxc-3.0.0.beta1~119^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F2021%2Fhead;p=thirdparty%2Flxc.git

overlay: fix out-of-bounds copy

Signed-off-by: Jonathan Calmels <jcalmels@nvidia.com>
---

diff --git a/src/lxc/storage/overlay.c b/src/lxc/storage/overlay.c
index ac7636192..f8632dcf1 100644
--- a/src/lxc/storage/overlay.c
+++ b/src/lxc/storage/overlay.c
@@ -410,15 +410,12 @@ int ovl_create(struct lxc_storage *bdev, const char *dest, const char *n,
 		return -1;
 	}
 
-	delta = malloc(len + 1);
+	delta = strdup(dest);
 	if (!delta) {
 		ERROR("Failed to allocate memory");
 		return -1;
 	}
-
-	memcpy(delta, dest, len);
 	memcpy(delta + len - 6, "delta0", sizeof("delta0") - 1);
-	delta[len + sizeof("delta0")] = '\0';
 
 	ret = mkdir_p(delta, 0755);
 	if (ret < 0) {