From: Victor Julien Date: Mon, 11 Jul 2016 07:30:26 +0000 (+0200) Subject: lua smtp: fix SMTPGetMimeField arg checking X-Git-Tag: suricata-3.1.1~6 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F2171%2Fhead;p=thirdparty%2Fsuricata.git lua smtp: fix SMTPGetMimeField arg checking Properly check argument before passing it on: CID 1363385: (NULL_RETURNS) --- diff --git a/src/util-lua-smtp.c b/src/util-lua-smtp.c index f18bea1b3c..a64c709832 100644 --- a/src/util-lua-smtp.c +++ b/src/util-lua-smtp.c @@ -112,6 +112,9 @@ static int SMTPGetMimeField(lua_State *luastate) return LuaCallbackError(luastate, "Error: no flow found"); } const char *name = LuaGetStringArgument(luastate, 1); + if (name == NULL) + return LuaCallbackError(luastate, "1st argument missing, empty or wrong type"); + /* lock check */ if(lock_hint == LUA_FLOW_NOT_LOCKED_BY_PARENT) { FLOWLOCK_RDLOCK(flow);