From: Jason Ish Date: Mon, 16 Jan 2017 16:44:19 +0000 (-0600) Subject: proto detect - fix coverity CID 1204325 X-Git-Tag: suricata-3.2.1~72 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F2489%2Fhead;p=thirdparty%2Fsuricata.git proto detect - fix coverity CID 1204325 CID 1204325 (#1 of 1): Logically dead code (DEADCODE) dead_error_line: Execution cannot reach this statement: mask = 0U;. 433 mask = 0; additionally, mask is initialized to 0 --- diff --git a/src/app-layer-detect-proto.c b/src/app-layer-detect-proto.c index f861349045..c82cc8d0d9 100644 --- a/src/app-layer-detect-proto.c +++ b/src/app-layer-detect-proto.c @@ -437,8 +437,6 @@ static AppProto AppLayerProtoDetectPPGetProto(Flow *f, mask = pp_port_dp->alproto_mask; else if (pp_port_sp) mask = pp_port_sp->alproto_mask; - else - mask = 0; if (alproto_masks[0] == mask) { FLOW_SET_PP_DONE(f, direction);