From: Tom Yu <tlyu@mit.edu>
Date: Wed, 4 Feb 2015 22:01:14 +0000 (-0500)
Subject: Avoid uninitialized data in t_prf.c
X-Git-Tag: krb5-1.14-alpha1~166
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F250%2Fhead;p=thirdparty%2Fkrb5.git

Avoid uninitialized data in t_prf.c

In t_prf.c, make sure that the partially initialized, faked-up
structures gss_union_ctx_id_desc and krb5_gss_ctx_id_rec are zeroed.
This avoids uninitialized reads in gss_pseudo_random(), which can
cause intermittent test failures on some platforms.

ticket: 8072 (new)
target_version: 1.13.1
tags: pullup
---

diff --git a/src/tests/gssapi/t_prf.c b/src/tests/gssapi/t_prf.c
index 7f0489995e..082edff934 100644
--- a/src/tests/gssapi/t_prf.c
+++ b/src/tests/gssapi/t_prf.c
@@ -124,8 +124,10 @@ main(int argc, char *argv[])
      * implementation.
      */
     context = (gss_ctx_id_t)&uctx;
+    memset(&uctx, 0, sizeof(uctx));
     uctx.mech_type = &mech_krb5;
     uctx.internal_ctx_id = (gss_ctx_id_t)&kgctx;
+    memset(&kgctx, 0, sizeof(kgctx));
     kgctx.k5_context = NULL;
     kgctx.established = 1;
     kgctx.have_acceptor_subkey = 1;