From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Tue, 31 Jul 2018 08:55:52 +0000 (+0200)
Subject: coverity: #438136
X-Git-Tag: lxc-3.1.0~182^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F2505%2Fhead;p=thirdparty%2Flxc.git

coverity: #438136

String not null terminated

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/tools/lxc_destroy.c b/src/lxc/tools/lxc_destroy.c
index e208cf6fd..90e53daa7 100644
--- a/src/lxc/tools/lxc_destroy.c
+++ b/src/lxc/tools/lxc_destroy.c
@@ -211,6 +211,7 @@ static bool do_destroy_with_snapshots(struct lxc_container *c)
 	char *lxcname = NULL;
 	int fd;
 	int ret;
+	ssize_t bytes;
 
 	/* Destroy clones. */
 	ret = snprintf(path, MAXPATHLEN, "%s/%s/lxc_snapshots", c->config_path, c->name);
@@ -233,9 +234,9 @@ static bool do_destroy_with_snapshots(struct lxc_container *c)
 			return false;
 		}
 
-		ret = lxc_read_nointr(fd, buf, fbuf.st_size);
+		bytes = lxc_read_nointr(fd, buf, fbuf.st_size);
 		close(fd);
-		if (ret < 0) {
+		if (bytes != (ssize_t)fbuf.st_size) {
 			ERROR("Could not read %s", path);
 			free(buf);
 			return false;