From: Pieter Lexis <pieter.lexis@powerdns.com>
Date: Tue, 29 Sep 2015 11:57:46 +0000 (+0200)
Subject: Use C++ auto-for with consts
X-Git-Tag: dnsdist-1.0.0-alpha1~248^2~27^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F2651%2Fhead;p=thirdparty%2Fpdns.git

Use C++ auto-for with consts
---

diff --git a/pdns/packethandler.cc b/pdns/packethandler.cc
index dbb62a15b0..9a2cc8f023 100644
--- a/pdns/packethandler.cc
+++ b/pdns/packethandler.cc
@@ -214,12 +214,12 @@ bool PacketHandler::addCDS(DNSPacket *p, DNSPacket *r, const SOAData& sd)
 
   DNSSECKeeper::keyset_t keyset = d_dk.getKeys(p->qdomain);
 
-  for(auto value : keyset) {
+  for(auto const &value : keyset) {
     if (!value.second.keyOrZone) {
       // Don't send out CDS records for ZSKs
       continue;
     }
-    for(auto digestAlgo : digestAlgos){
+    for(auto const &digestAlgo : digestAlgos){
       rr.content=makeDSFromDNSKey(p->qdomain, value.first.getDNSKEY(), lexical_cast<int>(digestAlgo)).getZoneRepresentation();
       r->addRecord(rr);
       haveOne=true;
diff --git a/pdns/tcpreceiver.cc b/pdns/tcpreceiver.cc
index 41064d9ced..c341605308 100644
--- a/pdns/tcpreceiver.cc
+++ b/pdns/tcpreceiver.cc
@@ -688,7 +688,7 @@ int TCPNameserver::doAXFR(const DNSName &target, shared_ptr<DNSPacket> q, int ou
         rr.qtype=QType(QType::CDS);
         vector<string> digestAlgos;
         stringtok(digestAlgos, publishCDS, ", ");
-        for(auto digestAlgo : digestAlgos) {
+        for(auto const &digestAlgo : digestAlgos) {
           rr.content=makeDSFromDNSKey(target, value.first.getDNSKEY(), lexical_cast<int>(digestAlgo)).getZoneRepresentation();
           cds.push_back(rr);
         }
@@ -733,10 +733,10 @@ int TCPNameserver::doAXFR(const DNSName &target, shared_ptr<DNSPacket> q, int ou
   vector<DNSResourceRecord> rrs;
 
   // Add the CDNSKEY and CDS records we created earlier
-  for (auto const rr : cds)
+  for (auto const &rr : cds)
     rrs.push_back(rr);
 
-  for (auto const rr : cdnskey)
+  for (auto const &rr : cdnskey)
     rrs.push_back(rr);
 
   while(sd.db->get(rr)) {