From: Noel Date: Fri, 3 Jun 2016 08:07:14 +0000 (+0100) Subject: Fix for chart title not updating X-Git-Tag: v2.1.5~17^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F2696%2Fhead;p=thirdparty%2FChart.js.git Fix for chart title not updating https://github.com/chartjs/Chart.js/issues/2686 Chart options were using a cache value from initialize function. Now updating values in the beforeUpdate lifecycle. --- diff --git a/src/core/core.title.js b/src/core/core.title.js index ab969d461..08d8a16bd 100644 --- a/src/core/core.title.js +++ b/src/core/core.title.js @@ -29,10 +29,15 @@ module.exports = function(Chart) { // These methods are ordered by lifecyle. Utilities then follow. - beforeUpdate: noop, + beforeUpdate: function () { + var chartOpts = this.chart.options; + if (chartOpts && chartOpts.title) { + this.options = helpers.configMerge(Chart.defaults.global.title, chartOpts.title); + } + }, update: function(maxWidth, maxHeight, margins) { - // Update Lifecycle - Probably don't want to ever extend or overwrite this function ;) + // Update Lifecycle this.beforeUpdate(); // Absorb the master measurements @@ -195,4 +200,4 @@ module.exports = function(Chart) { } } }); -}; \ No newline at end of file +};