From: Yann Collet Date: Wed, 8 Dec 2021 23:05:17 +0000 (-0800) Subject: remove offending static assert lines X-Git-Tag: v1.5.1~1^2~23^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F2914%2Fhead;p=thirdparty%2Fzstd.git remove offending static assert lines no idea why visual + clang-cl + appveyor don't like them, I've not been able to reproduce the issue locally, but these static assert are very unlikely to deliver a useful signal, I can't imagine a situation where they will be wrong, and if they are, then a ton of other things will be broken way before reaching that point. --- diff --git a/lib/common/xxhash.h b/lib/common/xxhash.h index eb095b93a..8ebbfdd62 100644 --- a/lib/common/xxhash.h +++ b/lib/common/xxhash.h @@ -2233,7 +2233,7 @@ XXH_PUBLIC_API XXH32_hash_t XXH32_digest(const XXH32_state_t* state) */ XXH_PUBLIC_API void XXH32_canonicalFromHash(XXH32_canonical_t* dst, XXH32_hash_t hash) { - XXH_STATIC_ASSERT(sizeof(XXH32_canonical_t) == sizeof(XXH32_hash_t)); + /* XXH_STATIC_ASSERT(sizeof(XXH32_canonical_t) == sizeof(XXH32_hash_t)); */ if (XXH_CPU_LITTLE_ENDIAN) hash = XXH_swap32(hash); XXH_memcpy(dst, &hash, sizeof(*dst)); } @@ -2631,7 +2631,7 @@ XXH_PUBLIC_API XXH64_hash_t XXH64_digest(const XXH64_state_t* state) /*! @ingroup xxh64_family */ XXH_PUBLIC_API void XXH64_canonicalFromHash(XXH64_canonical_t* dst, XXH64_hash_t hash) { - XXH_STATIC_ASSERT(sizeof(XXH64_canonical_t) == sizeof(XXH64_hash_t)); + /* XXH_STATIC_ASSERT(sizeof(XXH64_canonical_t) == sizeof(XXH64_hash_t)); */ if (XXH_CPU_LITTLE_ENDIAN) hash = XXH_swap64(hash); XXH_memcpy(dst, &hash, sizeof(*dst)); }