From: Victor Julien Date: Sat, 30 Sep 2017 14:50:47 +0000 (+0200) Subject: github: codeowners syntax fixes X-Git-Tag: suricata-4.0.1~21 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F2917%2Fhead;p=thirdparty%2Fsuricata.git github: codeowners syntax fixes --- diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 7e71bc8ce1..8a2e4b4e29 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,21 +1,15 @@ # https://help.github.com/articles/about-codeowners/ # # last match wins, so put more specific matches towards the end +# +# only ppl with push rights in the repo can be owners +# https://github.com/isaacs/github/issues/989#issuecomment-320475904 +# +# additionally, it seems only the directoy syntax works. +# e.g. '/src/source-*.[ch] @regit' seems to have no effect. * @OISF/core-team -rust/* @victorjulien @jasonish -src/source-* @regit -doc/* @norg -src/detect-engine* @victorjulien -*ssl* @thus @OISF/core-team -*tls* @thus @OISF/core-team -*nfs* @victorjulien -*dns* @jasonish -*ntp* @chifflier - -*prelude* @ToToL - -*napatech* @psanders240 - -.github/ @victorjulien +/doc/ @norg +/rust/ @victorjulien @jasonish +/.github/ @victorjulien