From: W. Felix Handte Date: Thu, 20 Jan 2022 22:36:28 +0000 (-0500) Subject: Trigger Release Artifact Generation on Publish X-Git-Tag: v1.5.4^2~272^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F3018%2Fhead;p=thirdparty%2Fzstd.git Trigger Release Artifact Generation on Publish We previously triggered release artifact generation on release creation. We sometimes observed that the action failed to run. I hypothesized that we were hitting rate limiting or something. I just stumbled across [this documentat- ion](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release), which says: > Note: Workflows are not triggered for the `created`, `edited`, or `deleted` > activity types for draft releases. When you create your release through the > GitHub browser UI, your release may automatically be saved as a draft. This must have been what was happening. This commit therefore changes the trigger to the `published` activity. This should be more reliable. This does have the unfortunate side effect that artifacts won't be generated or attached until *after* the release has been published, which is what I was trying to avoid by using the `created` activity. Oh well. --- diff --git a/.github/workflows/publish-release-artifacts.yml b/.github/workflows/publish-release-artifacts.yml index 952cb26b7..a87a75efa 100644 --- a/.github/workflows/publish-release-artifacts.yml +++ b/.github/workflows/publish-release-artifacts.yml @@ -3,7 +3,7 @@ name: publish-release-artifacts on: release: types: - - created + - published jobs: publish-release-artifacts: