From: Luca Boccassi <bluca@debian.org>
Date: Thu, 7 Mar 2024 00:51:43 +0000 (+0000)
Subject: resolve: disambiguate return statement
X-Git-Tag: v256-rc1~612^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F31664%2Fhead;p=thirdparty%2Fsystemd.git

resolve: disambiguate return statement

This works as expected, but coverity warns that it could be ambiguous and context
suggests the other way around. Add brackets to disambiguate.

CID#1535101

Follow-up for 6399be223b73ce520654242ad08de387b08b738a
---

diff --git a/src/resolve/resolved-dns-synthesize.c b/src/resolve/resolved-dns-synthesize.c
index 6f483fdf0e6..4e079864ec3 100644
--- a/src/resolve/resolved-dns-synthesize.c
+++ b/src/resolve/resolved-dns-synthesize.c
@@ -450,7 +450,7 @@ bool shall_synthesize_own_hostname_rrs(void) {
         if (r < 0 && r != -ENXIO)
                 log_debug_errno(r, "Failed to parse $SYSTEMD_RESOLVED_SYNTHESIZE_HOSTNAME: %m");
 
-        return (cached = r != 0);
+        return (cached = (r != 0));
 }
 
 int dns_synthesize_answer(