From: yiyuaner Date: Mon, 24 Oct 2022 12:37:15 +0000 (+0800) Subject: Fix the wrong check for buffer overrun in UTIL_mergeFileNamesTable X-Git-Tag: v1.5.4^2~133^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F3300%2Fhead;p=thirdparty%2Fzstd.git Fix the wrong check for buffer overrun in UTIL_mergeFileNamesTable --- diff --git a/programs/util.c b/programs/util.c index a3af26211..7c4bb451c 100644 --- a/programs/util.c +++ b/programs/util.c @@ -569,7 +569,7 @@ UTIL_mergeFileNamesTable(FileNamesTable* table1, FileNamesTable* table2) for( idx2=0 ; (idx2 < table2->tableSize) && table2->fileNames[idx2] && (pos < newTotalTableSize) ; ++idx2, ++newTableIdx) { size_t const curLen = strlen(table2->fileNames[idx2]); memcpy(buf+pos, table2->fileNames[idx2], curLen); - assert(newTableIdx <= newTable->tableSize); + assert(newTableIdx < newTable->tableSize); newTable->fileNames[newTableIdx] = buf+pos; pos += curLen+1; } }