From: Ben Darnell <ben@bendarnell.com>
Date: Thu, 11 Dec 2025 03:10:20 +0000 (-0500)
Subject: tox: Pin pycares version 4 due to backwards-incompatible changes
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F3556%2Fhead;p=thirdparty%2Ftornado.git

tox: Pin pycares version 4 due to backwards-incompatible changes
---

diff --git a/docs/caresresolver.rst b/docs/caresresolver.rst
index 4e0058ea..57caa7d1 100644
--- a/docs/caresresolver.rst
+++ b/docs/caresresolver.rst
@@ -19,6 +19,9 @@ wrapper ``pycares``).
     the default for ``tornado.simple_httpclient``, but other libraries
     may default to ``AF_UNSPEC``.
 
+    This class requires ``pycares`` version 4. Since this class is deprecated, it will not be
+    updated to support ``pycares`` version 5.
+
     .. deprecated:: 6.2
        This class is deprecated and will be removed in Tornado 7.0. Use the default
        thread-based resolver instead.
diff --git a/tox.ini b/tox.ini
index 88e8eb9d..db0a4b60 100644
--- a/tox.ini
+++ b/tox.ini
@@ -46,7 +46,10 @@ basepython =
 deps =
      full: pycurl
      full: twisted
-     full: pycares
+     # Pycares 5 has some backwards-incompatible changes that we don't support.
+     # And since CaresResolver is deprecated, I do not expect to fix it, so just
+     # pin the previous version. (This should really be in requirements.{in,txt} instead)
+     full: pycares<5
      docs: -r{toxinidir}/requirements.txt
      lint: -r{toxinidir}/requirements.txt