From: Mike Yuan <me@yhndnzj.com>
Date: Wed, 12 Feb 2025 16:38:47 +0000 (+0100)
Subject: core/service: drop unneeded unit_add_to_gc_queue()
X-Git-Tag: v258-rc1~1344^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F36368%2Fhead;p=thirdparty%2Fsystemd.git

core/service: drop unneeded unit_add_to_gc_queue()

Follow-up for a1d315730ffddf283d4bb9d73878fbcd97a4d244
and 6ac62d61db737b01ad3776a7688d8a4c57b3f7d9

With the aforementioned commits, unit_release_resources()
is dispatched in a dedicated queue, and Service.n_keep_fd_store
has been dropped, hence the comment is outdated. Moreover,
the unit is added to GC queue in unit_notify() already.
No other unit types do this in corresponding _enter_dead()
functions, nor does Service need it anymore.
---

diff --git a/src/core/service.c b/src/core/service.c
index 626a47f7a8f..dca8a43cb45 100644
--- a/src/core/service.c
+++ b/src/core/service.c
@@ -2152,10 +2152,6 @@ static void service_enter_dead(Service *s, ServiceResult f, bool allow_restart)
                 (void) unit_set_debug_invocation(UNIT(s), false);
         }
 
-        /* The new state is in effect, let's decrease the fd store ref counter again. Let's also re-add us to the GC
-         * queue, so that the fd store is possibly gc'ed again */
-        unit_add_to_gc_queue(UNIT(s));
-
         /* The next restart might not be a manual stop, hence reset the flag indicating manual stops */
         s->forbid_restart = false;