From: Christian Brauner <christian.brauner@ubuntu.com>
Date: Sat, 17 Apr 2021 15:46:37 +0000 (+0200)
Subject: commands: don't needlessly allocate
X-Git-Tag: lxc-5.0.0~202^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F3790%2Fhead;p=thirdparty%2Flxc.git

commands: don't needlessly allocate

Fixes: #3796
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
---

diff --git a/src/lxc/commands.c b/src/lxc/commands.c
index 08f4dea86..6e841b01a 100644
--- a/src/lxc/commands.c
+++ b/src/lxc/commands.c
@@ -286,7 +286,8 @@ static ssize_t lxc_cmd_rsp_recv(int sock, struct lxc_cmd_rr *cmd)
 		}
 		return syserror_set(-ENOMEM, "Failed to receive response for command \"%s\"", cur_cmdstr);
 	case LXC_CMD_CONSOLE_LOG:		/* data */
-		__data = zalloc(rsp->datalen + 1);
+		if (rsp->datalen > 0)
+			__data = zalloc(rsp->datalen + 1);
 		rsp->data = __data;
 		break;
 	default:				/* catch any additional command */