From: Philippe Antoine <contact@catenacyber.fr>
Date: Wed, 3 Jul 2019 13:26:08 +0000 (+0200)
Subject: leak: fixes leak in DetectAddressParse2
X-Git-Tag: suricata-5.0.0-rc1~218
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F3994%2Fhead;p=thirdparty%2Fsuricata.git

leak: fixes leak in DetectAddressParse2
---

diff --git a/src/detect-engine-address.c b/src/detect-engine-address.c
index 25ea2dc0d3..682d864721 100644
--- a/src/detect-engine-address.c
+++ b/src/detect-engine-address.c
@@ -885,8 +885,11 @@ static int DetectAddressParse2(const DetectEngineCtx *de_ctx,
                     DetectAddressHead tmp_gh = { NULL, NULL };
                     DetectAddressHead tmp_ghn = { NULL, NULL };
 
-                    if (DetectAddressParse2(de_ctx, &tmp_gh, &tmp_ghn, address, 0, var_list) < 0)
+                    if (DetectAddressParse2(de_ctx, &tmp_gh, &tmp_ghn, address, 0, var_list) < 0) {
+                        DetectAddressHeadCleanup(&tmp_gh);
+                        DetectAddressHeadCleanup(&tmp_ghn);
                         goto error;
+                    }
 
                     DetectAddress *tmp_ad;
                     DetectAddress *tmp_ad2;