From: Zbigniew Jędrzejewski-Szmek <zbyszek@amutable.com>
Date: Tue, 5 May 2026 20:08:19 +0000 (+0200)
Subject: homectl: drop redunant sort
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F41954%2Fhead;p=thirdparty%2Fsystemd.git

homectl: drop redunant sort

Claude points out that prompt_groups() already does the sort
in every loop, including the last.
---

diff --git a/src/home/homectl.c b/src/home/homectl.c
index 56e723fbfef..ce54da0d8c2 100644
--- a/src/home/homectl.c
+++ b/src/home/homectl.c
@@ -2734,8 +2734,6 @@ static int create_interactively(void) {
                         return r;
 
                 if (!strv_isempty(groups)) {
-                        strv_sort_uniq(groups);
-
                         r = sd_json_variant_set_field_strv(&arg_identity_extra, "memberOf", groups);
                         if (r < 0)
                                 return log_error_errno(r, "Failed to set memberOf field: %m");