From: Michal Sekletar <msekleta@redhat.com>
Date: Tue, 27 Aug 2024 15:59:15 +0000 (+0200)
Subject: Prevent icmp_socket leak on error
X-Git-Tag: v0.96~11^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F515%2Fhead;p=thirdparty%2Fmtr.git

Prevent icmp_socket leak on error
---

diff --git a/packet/probe_unix.c b/packet/probe_unix.c
index 00ec7a2..7362d6d 100644
--- a/packet/probe_unix.c
+++ b/packet/probe_unix.c
@@ -296,6 +296,7 @@ int open_ip4_sockets_dgram(
     }
 #ifdef HAVE_LINUX_ERRQUEUE_H
     if (setsockopt(icmp_socket, SOL_IP, IP_RECVERR, &val, sizeof(val)) < 0) {
+        close(icmp_socket);
         return -1;
     }
 #endif
@@ -386,6 +387,7 @@ int open_ip6_sockets_dgram(
     }
 #ifdef HAVE_LINUX_ERRQUEUE_H
     if (setsockopt(icmp_socket, SOL_IPV6, IPV6_RECVERR, &val, sizeof(val)) < 0) {
+        close(icmp_socket);
         return -1;
     }
 #endif