From: Shchelkunov Artem Date: Fri, 20 Aug 2021 12:52:14 +0000 (+0500) Subject: Fix: dereferencing a null pointer X-Git-Tag: release-1.14.0rc1~5^2 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F530%2Fhead;p=thirdparty%2Funbound.git Fix: dereferencing a null pointer Found by static analyzer svace Static analyzer message: Return value of a function 'reply_info_copy' is dereferenced at dns64.c:923 without checking, but it is usually checked for this function (4/5). on-behalf-of: @ideco-team --- diff --git a/dns64/dns64.c b/dns64/dns64.c index c79bc9c65..8872f10b0 100644 --- a/dns64/dns64.c +++ b/dns64/dns64.c @@ -913,8 +913,9 @@ dns64_adjust_ptr(struct module_qstate* qstate, struct module_qstate* super) sizeof(struct dns_msg)))) return; super->return_msg->qinfo = super->qinfo; - super->return_msg->rep = reply_info_copy(qstate->return_msg->rep, NULL, - super->region); + if (!(super->return_msg->rep = reply_info_copy(qstate->return_msg->rep, + NULL, super->region))) + return; /* * Adjust the domain name of the answer RR set so that it matches the