From: Jason Ish <jason.ish@oisf.net>
Date: Sun, 10 Oct 2021 05:10:35 +0000 (-0600)
Subject: runner: fix tests always being run in quiet mode
X-Git-Tag: suricata-6.0.4~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=refs%2Fpull%2F558%2Fhead;p=thirdparty%2Fsuricata-verify.git

runner: fix tests always being run in quiet mode

Fix an early return introduced in
9839097b816d2f7e1cb00d4f4e98919565d122a1, which resulted in a quiet like
mode all the time.
---

diff --git a/run.py b/run.py
index 39dd6a523..3b7ae08cc 100755
--- a/run.py
+++ b/run.py
@@ -646,7 +646,6 @@ class TestRunner:
                     r, expected_exit_code));
 
             check_value = self.check()
-            return check_value
 
         if not check_value["failure"] and not check_value["skipped"]:
             if not self.quiet:
@@ -711,9 +710,6 @@ class TestRunner:
         if count["failure"] or count["skipped"]:
             return count
 
-        # Covering cases like "tests/show-help" which do not have
-        # check.sh and/or no checks in test.yaml should be counted
-        # successful
         success_c = count["success"]
         count["success"] = 1 if not success_c else success_c